freshmaker

#515 Removing usage of git archive to get 'container.yaml' and 'content_sets.yml' files
Merged by gnaponie. Opened by apaplaus.
apaplaus/freshmaker replace-git-archive  into  master

Download 515.patch

Remove git archive calls to git-dist, remove unused code associated with this functionality and tests for them. Add test for new replacing code.

RESOLVES: FACTORY-5861 and FACTORY-5860

1 new commit added

  • Code style fixes + remove unsused imports

@jkaluza could you review if you have time? To double check if that was what you had in mind when we discussed about it.

It seems the right approach to me. Let's see if @jkaluza is also of the same opinion before we continue with the review.

@gnaponie, this looks good to me. I presume we have checked somehow that all the latest shipped container images have the content_sets set so there is no need to use the git archive anymore right?

I think that's what we did in the spike card that was done before that. I'll double check.

Checked this once again, I tried to test it also locally with dev_scripts/find_images_to_rebuild.py and this seems correct to me. @apaplaus could you remove the WIP state so maybe we can merge this?

Checked this once again, I tried to test it also locally with dev_scripts/find_images_to_rebuild.py and this seems correct to me. @apaplaus could you remove the WIP state so maybe we can merge this?

Done

rebased onto b2d3af712fdf5da1b5b2627aa22d07809979b535

+1 let's merge this.

Pull-Request has been merged by gnaponie
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.