#518 Build container image without an RPM
Merged by gnaponie. Opened by lucarval.
dont-build-rpm  into  master

Download 518.patch

Prior to this commit, the process of building a container image for
Freshmaker created a temporary RPM which was then installed in the
container image.

Given that the RPM is immediately discarded, and that Freshmaker is
never distributed as an RPM, this process is unnecessarily complex.

This commit removes the RPM build process completely and simply builds
the container image directly from source.

Because Freshmaker is not installed from an RPM, its contents are found
in a different location. Previously, the freshmaker-* console scripts
were installed under /usr/bin, but now they're under /usr/local/bin.
This is also true for the python package. It has moved from
/usr/lib/python3.7/site-packages/freshmaker to
/usr/local/lib/python3.7/site-packages/freshmaker

This change in path is expected as /usr/local is meant for content not
provided by the Linux distribution itself.

Also, man pages for the freshmaker-* console scripts are no longer
generated. There appears to be no value in generating those.

Signed-off-by: Luiz Carvalho lucarval@redhat.com

wip: will this work?!

Signed-off-by: Luiz Carvalho lucarval@redhat.com

rebased onto ac21de29896d481ae377061d0f417d6bc897b8a6

+1 for the general idea. RPM was used back then when we actually installed Freshmaker from RPM on real VMs. There is no reason to use it with container images.

I have not checked the PR, I think you should just give it a try on freshmaker dev and see :)

Let's try this +1

Commit 3c8674ca fixes this pull-request

Pull-Request has been merged by gnaponie

Pull-Request has been merged by gnaponie

It looks like the CA is installed later in the Dockerfile using cacert_url. Why not add the CA before doing this?

It looks like the CA is installed later in the Dockerfile using cacert_url. Why not add the CA before doing this?

Because we only install the ca cert if we're building the image internally, but we need the internal repo in all cases to install rhmsg.

I didn't want to add even more complexity to this PR.

Metadata