From 17eb0d55cacbead71603f4d8c17c22688d14d4f3 Mon Sep 17 00:00:00 2001
From: Giulia Naponiello <gnaponie@redhat.com>
Date: Apr 14 2020 15:24:53 +0000
Subject: Bug fix: Freshmaker was not always building modules


Freshmaker enabled support for building modules some time ago, but it
seems like it was not enabled everywhere. Because of that some
modules were not built. Let's fix that.

ref: CLOUDWF-1038

Signed-off-by: Giulia Naponiello <gnaponie@redhat.com>

---

diff --git a/freshmaker/handlers/internal/update_db_on_advisory_change.py b/freshmaker/handlers/internal/update_db_on_advisory_change.py
index 41c7268..15a9a98 100644
--- a/freshmaker/handlers/internal/update_db_on_advisory_change.py
+++ b/freshmaker/handlers/internal/update_db_on_advisory_change.py
@@ -46,7 +46,7 @@ class UpdateDBOnAdvisoryChange(BaseHandler):
         if not isinstance(event, ErrataAdvisoryStateChangedEvent):
             return False
 
-        if 'rpm' not in event.advisory.content_types:
+        if not {'rpm', 'module'} & set(event.advisory.content_types):
             log.info('Skip non-RPM advisory %s.', event.advisory.errata_id)
             return False
 
diff --git a/tests/handlers/internal/test_update_db_on_advisory_change.py b/tests/handlers/internal/test_update_db_on_advisory_change.py
index ef18ac8..2545351 100644
--- a/tests/handlers/internal/test_update_db_on_advisory_change.py
+++ b/tests/handlers/internal/test_update_db_on_advisory_change.py
@@ -231,12 +231,13 @@ class TestUpdateDBOnAdvisoryChange(helpers.ModelsTestCase):
 
 class TestSkipNonRPMAdvisory(helpers.FreshmakerTestCase):
 
-    def test_ensure_to_handle_rpm_adivsory(self):
-        event = ErrataAdvisoryStateChangedEvent(
-            'msg-id-1',
-            ErrataAdvisory(123, 'name', 'REL_PREP', ['rpm', 'jar', 'pom']))
-        handler = UpdateDBOnAdvisoryChange()
-        self.assertTrue(handler.can_handle(event))
+    def test_ensure_to_handle_rpm_and_module_adivsory(self):
+        for content_type in ['rpm', 'module']:
+            event = ErrataAdvisoryStateChangedEvent(
+                'msg-id-1',
+                ErrataAdvisory(123, 'name', 'REL_PREP', [content_type, 'jar', 'pom']))
+            handler = UpdateDBOnAdvisoryChange()
+            self.assertTrue(handler.can_handle(event))
 
     def test_not_handle_non_rpm_advisory(self):
         event = ErrataAdvisoryStateChangedEvent(