Store the Freshmaker event as a member variable in the LightBlue class.
The CI (specifically flake8) fails complaining about this line: we should remove it.
I'd just call it event_id instead of freshmaker_event_id since freshmaker seems redundant.
event_id
freshmaker_event_id
freshmaker
I believe you miss an additional change in freshmaker/handlers/koji/rebuild_images_on_rpm_advisory_change.py When instantiating the LightBlue class you should pass in there the id of the event. It should be available in there accessing self.event. I believe this should be the only place.
freshmaker/handlers/koji/rebuild_images_on_rpm_advisory_change.py
self.event
rebased onto d03c8bf0303ce7a0fbedef7608f414a46486fec4
rebased onto fcecbe99976a766855d956c96cecb6fbf2bec0ea
rebased onto a489de418e338bfea7ed01ac60908c376193bb6e
rebased onto c6a601dab9e41280b2afe9e80c85c139823c83d7
@gnaponie , PTAL :)
Flake8 complains about: ./tests/handlers/koji/test_rebuild_images_on_rpm_advisory_change.py:592:42: E231 missing whitespace after ','
I guess it's this line. (pagure doesn't show the real line so I'm not 100% sure, but it should be this one...)
Could you remove the WIP state if it's ready?
Mmm now that I see this test... don't hate me :D but maybe it would be more appropriate to add it to tests/test_lightblue.py since in the end we didn't add any test for _find_images_to_rebuild.
_find_images_to_rebuild
rebased onto c60a720ce0d4ca17a87cab739037a206a80e03e1
rebased onto 0b43d074e8a7311d0d9f5cd10d083c437ad312b9
@gnaponie , take a look one more time. I'll remove WIP state after it :)
This if statement is not necessary.
rebased onto 9efe378d0d449276c7d3c50632d33a24f9533ebf
Fixed
Looks good to me +1
Commit 05770276 fixes this pull-request
Pull-Request has been merged by mulaieva
Store the Freshmaker event as a member variable in the LightBlue class.