PR#57: Add APIs for querying event types, build types and build states -

no initial comment

rebased

Jun 29, 2017

Will this return the "No such event type found." to the user with a 500 error?

Seems like a 404 would be most appropriate.

In general, looks good. :+1: to merge, although I'd advise reconsidering the exception handling if it is throwing 500 errors back to the user.

Same above. 404 would be good.

Same above. 404 would be good.

LGTM.

It would be good to raise 404 if id is None, if freshmaker does not do that now.

rebased

Jul 10, 2017

updated to return 404 for 'Not Found' errors and rebase to latest master.

:thumbsup:

Pull-Request has been merged by qwan

Jul 10, 2017

Assignee

None

Tags

No Tags