Is this correct summary?

How about change this to: Freshmaker is a service scheduling rebuilds of artifacts as new content becomes available ?

Better. When I saw "Continuous Compose Service" for the first time, I feel it describes something else like ODCS.

don't hardcode 2.7.... use %{python2_version}

python2-six

not needed

in general looks good apart from dozens of python- prefixed packages.

@ignatenkobrain thanks for your review, updated per your comments, changed some 'python-' prefixed name to python2-. However 'python-six' is not changed since I found the package name is actually python-six rather than python2-six, though dnf can query or install python-six when python2-six is specified.

+1

Any reason not to merge this?

Was looking on https://bugzilla.redhat.com/show_bug.cgi?id=1468971 for further comments, however that should not block this. Since F26 was just GA, I'll make some changes to package names of the dependencies and then merge this.

I'll make some changes to package names of the dependencies and then merge this.

:+1: :)

Updated some python- prefix package names.

f26 has been released and according to Maintenance_Schedule[1] f24 should reach EOL in a month soon. Do we need to build f24 package?

[1] https://fedoraproject.org/wiki/Fedora_Release_Life_Cycle#Maintenance_Schedule

What is the target Fedora and RHEL release within which to deploy freshmaker? Why do we need to consider to build packages for multiple Fedora and RHEL releases?

I'm thinking if we only need to build package for single Fedora or RHEL release, spec file could be simplified.

%if 0%{?rhel} && 0%{?rhel} <= 7

%if (0%{?fedora} && 0%{?fedora} < 26) || (0%{?rhel} && 0%{?rhel} <= 7)

and invert logic

this is wrong even on EL6

I think it makes sense to support 25 and 26 for fedora, 24 is not that important and I don't expect to enable f24 branch for freshmaker. Anyway I'll check Igor's comments on the current version of spec file. https://bugzilla.redhat.com/show_bug.cgi?id=1468971

you should really reverse logic in such situations, it should be for F<26 || EL<=7 rather

If not going to build f24 package, python2-koji can be required always.

Updated package (build) dependencies:
1. Not going to support <= f25
2. For EL7, still have koji in buildrequires, as yum still can't see koji 1.13 at this moment, so before koji 1.13 is available or override is set for koji, this is a workaround to get build pass on EL7.

@qwan just as a heads up, I packaged fedrepo-req recently and a Bugzilla ticket was created yesterday telling me to package for Python 3 as well since the upstream supports it. You may want to consider packaging for Python 3 to begin with to save you the hassle from implementing it later on if all your dependencies are packaged for Python 3.

@qwan I think you are free to create an override in bodhi for koji-1.13 in order to build freshmaker.

@qwan just as a heads up, I packaged fedrepo-req recently and a Bugzilla ticket was created yesterday telling me to package for Python 3 as well since the upstream supports it. You may want to consider packaging for Python 3 to begin with to save you the hassle from implementing it later on if all your dependencies are packaged for Python 3.

Good point, I'll check with team on the plan of supporting Python 3, our code can run under Python 3 but not sure whether we need to support it and whether all the dependencies have Python 3 packages.

+1

rebased to merge