freshmaker

#70 Add handler for brew container built event
Merged by qwan. Opened by qwan.
qwan/freshmaker brew-container-built  into  master

Download 70.patch

In BrewSignRpmHandler, we record all the planned Docker image builds
into database. They have the state PLANNED and they have the
ArtifactBuild.dep_on set properly according to dependencies between
these images.

When the a container is built in brew, we should rebuild containers
that depends on it. At this moment, we only log the builds which need to
be rebuilt.

This is really hard to understand. Could we use a simple way to parse this git_url? For example,

result = urlparse.urlparse('git://dist-git-qa.app.eng.bos.redhat.com/rpms/osbs-test-sandwich-docker#813fa22')
container = result.path.rsplit('/')[-1]

I'm OK with both ways how to do that. urlparse seems easier to read, but the regexp is not extremely complex.

Looks OK to me. Feel free to use urlparse if you think it's good. I don't mind keeping the regexp there. Either use urlparse or merge or discuss with cqi :). +1 from me.

rebased

+1

Hm, this handler should handler also "failed" state when docker image rebuild failed for some reason and update the database.

+1

rebased

I think this should be also eng.brew.task.failed. Otherwise +1, feel free to merge after fixing this :).

rebased

Pull-Request has been merged by qwan
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.