...to avoid generating...
Probably better: Skipping Errata advisory %d to be marked as released
@cqi, I left some comments. :thumbsup: from me otherwise
rebased
@fivaldi Thank you. Fixed those you mentioned in comment.
1 new commit added
I think it will be better to have build_id as required param, it will be hard to find out the build id in build system if we don't set it after the build/task is created. Maybe we can even consider on changing model to have build_id to not nullable?
ok, I forgot the 'planned' builds, just ignore this.
Ready for review.
I always preferred following format:
builds = self._find_and_record_images_to_rebuild( ev, event, builds)
I find that easier to read, but if you guys think you like this more, +1. Is there some recommendation on formatting which can we follow in this case?
Just left comment here about formatting, otherwise +1.
Changed to code layout according to Jan's comment, it really makes code easier to read for this case. Also rebased on master branch. Please review again.
+1
Pull-Request has been merged by cqi