freshmaker

#92 Fix various issues found by testing Freshmaker with real depending services:
Merged by jkaluza. Opened by jkaluza.
jkaluza/freshmaker dry-run-fixes  into  master

Download 92.patch
  • When FRESHMAKER_CONFIG_FILE is defined, load it even when using DEVELOPER_ENV.
  • Get the git branch name from the Brew build instead of setting it to "unknown"
    every time.
  • Set container image release to XX.timestamp instead of XX.YY.timestamp.
  • Pass models.py Event instance to prepare_yum_repo instead of events.py Event
    instance.
  • Remove call of non-existing _build_first_batch method in Errata handler.
  • Pass full config file to Koji.
  • Fix bug when Koji build was always 'scratch' build.
  • Do not include ".eng" in topic suffix for handler, this should be part of
    TOPIC_PREFIX configuration.

release = "{}.{:d}".format(version, time.time()) ?

Overall, this looks good. Since it was derived from practical testing, I'm inclined to just :+1: it. It is kind of hard to review since there are so many changes bundled into one PR. Will read through it again.

OK. :+1:.

I'm assuming there will be a new PR coming with the msg['headers']['message-id'] fix.

Pull-Request has been merged by jkaluza
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.