JIRA: RHELWF-704
Signed-off-by: Valerij Maljulin vmaljuli@redhat.com
Why did you rename the variable? I couldn't figure it out from the commit subject: "Flask fix (ambigous variable name)"
Why did you rename the variable? I couldn't figure it out from the commit subject: "Flask fix (ambiguous variable name)"
because, according to PEP8, variables couldn't use names I, l, and O as ambiguous.
I
l
O
because, according to PEP8, variables couldn't use names I, 'l', and 'O' as ambiguous.
Oh, OK; found it: https://www.python.org/dev/peps/pep-0008/#names-to-avoid
Please fix the commit subject ("Flask fix" doesn't make sense and it doesn't mention PEP8).
rebased onto 086bc71f5b7a8475b4e801586da2e956145c556c
Done
There is a typo in subject text: "requirments"
Otherwise, all good.
+1
2 new commits added
Duplicate requirements removal
Flask fix (ambigous variable name 'l' according to PEP8)
looks good!
rebased onto 6de0b965c7fb2d9b014c9a246486d4fdbf29c73f
Pull-Request has been merged by vmaljulin
JIRA: RHELWF-704
Signed-off-by: Valerij Maljulin vmaljuli@redhat.com