gssproxy

#163 Add support for setting the NO Ci Flags credentials option
Closed by rharwood. Opened by simo.
simo/gssproxy setcredopt  into  master

Download 163.patch
no initial comment

Please rebase this onto master.

rebased

 
Testing setting credential options...
Traceback (most recent call last):
  File "./tests/runtests.py", line 73, in <module>
    r = t.run(testdir, gssapienv, basicconf)
  File "/home/bos/rharwood/gssproxy.git/proxy/tests/t_setcredopt.py", line 38, in run
    return run_cmd(testdir, env, conf, socket, cmd, False)
NameError: name 'socket' is not defined

3 new commits added

  • Insure tests failure on traceback
  • Add test to check setting cred options
  • Add support for the NO_CI_FLAG credentials option

Are we allowing this now?

Should probably be 2017

Multiline please.

We should allow for more than one round trip here probably

This year also seems wrong

Typo?

Some comments inline. Most of this I'd fixup at merge time, but I don't know what we want to do about the for loops, and I don't feel comfortable touching copyright information.

So here is the thing, if it is on the same line there is no risk of adding errors,
if it is on two lines with brackets also no problem, you add content in brackets, but the form

if (x)
    foo();

I find it dangerous, because you can add a line after and forget to add {}, which is why I am ok returning inline if it is this short rather then going next line.

For this test it is ok, we force krb5 which requires only one roundtrip

Fixed up what I think needs fixin'
C99 or even C11 is just fine by me.

3 new commits added

  • Insure tests failure on traceback
  • Add test to check setting cred options
  • Add support for the NO_CI_FLAG credentials option

Thanks, pushed to master as e406ad52f9bf0aa6a6894a19f32094bbc4a22531

Pull-Request has been closed by rharwood
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.