ipsilon

#189 Ipsilon requires a NameIDPolicy in the SAML Login request
Closed: Fixed Opened by rcritten.

Closed: Fixed
Reopen Issue

Ipsilon requires a NameIDPolicy in the SAML Login request but it is optional per the SAML 2.0 spec in section 3.4.1.1.

This is causing a login from salesforce.com to fail because it doesn't provide a Subject at all (which is also optional).

Ok, so this is two bugs in: ipsilon/providers/saml2/provider.py

The first bug is that the debug statement comes before the None check.

The second is that 'if nip.format is None:' should be 'if nip is None or nip.format is None':

And the debugging moved into the conditional.

Fields changed

owner: => rcritten
status: new => accepted

https://pagure.io/ipsilon/pull-request/44

patch_available: 0 => 1

master: 992492e0f2f526cd07e63b03cd70a81fca6a94ec

resolution: => fixed
status: accepted => closed

Metadata Update from @rcritten:
- Issue assigned to rcritten
- Issue set to the milestone: 1.2
Metadata
None
None
None
Normal
defect
Interoperability
0
1
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.