ipsilon

#225 Root-mounted instance has invalid openid base redirect
Closed: Fixed Opened by puiterwijk.

Closed: Fixed
Reopen Issue

If the instance is mounted on the web root (/), the openid redirect to the root (raise cherrypy.HTTPRedirect(self.basepath)) does not work and redirects to the /openid endpoint again, resulting in an endless redirect.

We should either change that line to use "self.basepath or '/'" or set basepath to '/'.

Another idea brought out was to use posixpath.join() everywhere instead of manually glueing strings together, as that would be more stable with regards to preventing double slashes and more.

Patch at https://pagure.io/ipsilon/pull-request/124

status: new => accepted

This has been merged with f28a28c46b8c234b070eef2329195f9b064af93c.

resolution: => fixed
status: accepted => closed

Metadata Update from @puiterwijk:
- Issue assigned to puiterwijk
- Issue set to the milestone: 1.3
Metadata
None
None
None
Normal
defect
OpenID
Development
0
0
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.