#122 Implement OpenID Connect static clients and admin
Merged by puiterwijk. Opened by puiterwijk.
puiterwijk/ipsilon oidc-static-clients  into  master

Download 122.patch
no initial comment

Please do look at this per commit, as I tried to split everything into the correct commits.

I'm a little curious about the use of WARN for something that is described as an error.

is cid used anywhere?

delete is a regular function, but I'm not finding a public_function attribute to regular functions, is this something internal to Cherrypy?

What about using .get() here?

Same about .get()

And here as well :)

Yes, in the raise cherrypy.HTTPRedirect('%s/client/%s' just below this.

I wonder if it would make sense to keep all these info in a dict and just use that dict here in the code

Yes, this is something in cherrypy to indicate that this function is meant to be dispatched to. It's the same as "exposed".

So no more S-?

With the new ConfigHelper-type system, I'm sure that this attribute has been set, as it's always generated.

No. I thought I'd do D- for dynamic and S- for static, but now I just do D- for dynamic and everything else is a static client.

  • onclick="return confirm('Do you really want to remove this user?');"

ah indeed, thanks

Few questions (most already covered), one suggestion, nothing standing out to me.

:thumbsup: for me

Because we use Error for errors in the system, whereas warn is for user errors that they can fix themselves.

Maybe self.name, for consistency? Either works, though.

This concerns be a bit, as the default cherrypy translation is converting all of
!"#$%&'()*+,-./:;<=>?@[]^{|}~ to underscores. Instead of this, how about: transchars = '!"#$%&\'()*+,/:;<=>?@[\\]^_{|}~'
trans = string.maketrans(transchars, '
' * len(transchars))

sigh mangled formatting, but you get the idea.

rebased

I get what this is used for, but the name is a bit confusing. Also, do we want . in there too?

6 new commits added

  • Test basic OpenIDC administration code
  • Implement OpenID Connect static clients
  • Implement OpenID Connect Client configuration as ConfigHelper
  • Disable the cherrypy dispatch method translation for dot and hyphen
  • Add Integer configuration field type
  • Throw new FieldError to indicate which option field is problematic

That's all I had. Looks good.

rebased

Pull-Request has been merged by puiterwijk

Metadata