ipsilon

#303 Fix race condition in OpenIDConnect api
Closed by puiterwijk. Opened by bkabrda.
bkabrda/ipsilon fix-oidc-api-race-condition  into  master

Download 303.patch

Cherrypy seems to reuse objects if running in a multithreaded environment
(e.g. mod_wsgi on httpd). This can result in multiple threads resetting
attributes of OpenIDConnect api objects which then leads to various 500
errors. A fresh cherrypy.request object is generated for every request,
therefore it can be used to store these attributes safely.

Related: #302

Signed-off-by: Slavek Kabrda bkabrda@redhat.com

FWIF, the Jenkins failure doesn't seem to be related:

rpmbuild --define "gittag .git`git rev-parse --short HEAD`" --define "builddate .`date +%Y%m%d%H%M`" --define "_topdir /srv/jenkins/workspace/Ipsilon/dist/rpmbuild" -ba contrib/fedora/ipsilon.spec
error: line 24: Duplicate BuildArch entry: BuildArch:      noarch

LGTM

Thanks for this patch, it is merged in f651d2cc84dc2c67782acf8081a425ec6a84b4af.
Unfortunately, you introduced some style issues, but given the delay in reviewing I decided to just fix those up in 357e0fb9c5980b993baba1226941725c6454089f.

Pull-Request has been closed by puiterwijk
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.