#319 Add theming capabilities
Merged by ngompa. Opened by hellcp.
hellcp/ipsilon master  into  master

Download 319.patch

Adds theming with a drop-in directory and 2 themes.

:thumbsup:

I like this commit, but I do not understand how the default theme works, i see the code mentions the directory 'themes/default', but the commit does not add such directory, it only adds Fedora and OpenSUSE directories under themes

Yeah, I implemented default theme for the /ui directory, but I realized there is no easy way to override the assets and keep the other assets hosted like there is to override templates. I will just remove it.

1 new commit added

  • Only use theme_dir if it's set

2 new commits added

  • Only use theme_dir if it's set
  • Add theming capabilities

1 new commit added

  • Update the openSUSE theme

@hellcp Could you squash the update to the openSUSE theme into the commit that adds the theme in the first place?

rebased onto f10cfe7fb1f3b632e373a6c1f0c409f9cdd07fb4

Another question, why the /res directory ?
I understand it mean "resources", but why do you need another high level directory? why /ui is not sufficient ?

For the sake of compartmentalization, I didn't want to just place content of every theme in one directory. I also can't override the default /ui because some templates still use data from that directory.

Sure but why not simply /ui/res ?

1 new commit added

  • Move res to ui

2 new commits added

  • Only use theme_dir if it's set
  • Add theming capabilities

@simo ping?

Looks good, if you can squash the two commits I will push

rebased onto 2aa82185ad08a3b4cae5705d9bfe736e849e1355

rebased onto 1cd7e589366ccbf93cdef29e34eab4fb571dc92f

Pull-Request has been merged by ngompa

Metadata