ipsilon

#340 providers/openidc: Do not stringify empty array for 'amr' when setting up auth response
Merged by ngompa. Opened by ngompa.
ngompa/ipsilon oidc-amr-json  into  master

Download 340.patch

We transform the whole authentication response dictionary into JSON later on, so
we do not need to do it while building the dictionary.

Fixes #339

Signed-off-by: Neal Gompa ngompa13@gmail.com

@simo, could you please review this?

Is this 'amr' even used? I see no other reference in the file.

Unfortunately I do not remember much of this provider, so I cannot say if this change is correct, it will change the serialization though. Are there any tests that verify this change is ok?

Ah I read #339 now ... so there is in field proof this is wrong.

LGTM

@simo We need to fix the test suite and get it running again in CI. Changes are scary without it...

Pull-Request has been merged by ngompa
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.