#353 Use a separate field for OTP in Fedora
Merged by ngompa. Opened by abompard.
abompard/ipsilon otp-field  into  master

Download 353.patch

Concatenate the OTP field to the password field if it is in the form post. Don't touch non-Fedora templates.

@abompard Is there a reason you can't adjust the other templates? It seems relatively simple...

Yeah but other instances may not be using OTP tokens. Should I add the field nonetheless?

Yeah, please do so. Even in Fedora, not everyone is using OTPs, so the field has to note that it's optional if you don't have it configured anyway.

rebased onto 14483a111f919a770c70a79ef19d554107bf12bd

rebased onto c7f8fc3e6b002f7a3a927c1fad03760d9201c82c

@abompard Can you also add it to the default theme? https://pagure.io/ipsilon/blob/master/f/templates/login/form.html

rebased onto b68a5e30ad98fca7e058b292f8f2abe6fa1e9e42

Whoops, missed it, sorry. I had to adjust the CSS a bit, which made me realize ipsilon is using Bootstrap 3.x... :older_man:

Yeah, someday we should move to Bootstrap 4...

Pull-Request has been merged by ngompa

It's even 5 these days ;-)

Metadata