closes 58

Hello guys, thanks for the PR, it looks good! :)

I will add a few inline comments for you so we can work on merging this.

Also, it is a good practice to keep the commit message in the imperative form. If you want to do so, just substitute changing for change.

Is this change part of this PR? I understand there seems to be a mistake in the code here, thanks for getting that. But it would be nice to have that in a separate commit, if this is the case. Would you like to do that?

This is an example configuration file that must always be reviewed and changed by the user. Are there any reasons for doing this in this PR? Is it part of it?

If not, I do not oppose to deactivating the (useless) example fetcher, but if you want to do that, do so in a different commit/PR.

Changed the commits messages and accepted the suggestions. Sorry for the kiskadee.conf change, it was a mistake that passed by.

Why are we adding a commented line here?

Sorry, didn't noticed that, thanks for pointing it out. Fixed it.

@danilobarros please, make a rebase with the master branch.

Before merging this, please, remove the commented line I pointed above (this was not fixed yet).

Rebase made and commented line removed.

Almost there.

@danilobarros, when a commit message has multiple lines, it is a nice convention to have a blank line after the first one. It would be nice to follow these good practices in the project, and wherever you send patches in the future. Would you fix your commit messages?

If you want to learn more about commit messages, here is a nice source

Sorry, didn't know about that.

Fixed the commit messages. Thank you for the update.

Another good source on writing good commit messages that I found, by Linus Torvalds.

@danilobarros, thanks for the fixes.

Sorry for being picky on your commits, but I believe this will help you guys in future contributions to FLOSS projects:

Signed-off-by: gabrielsclimaco gabielsclimaco@gmail.com
Signed-off-by: DaniloBarros <dan.b412@gmail.com>

The Signed-off-by messages should have your names there: like Danilo Barros and Gabriel SURENAME. It is ok if you guys prefer to use nicknames, as long as you are always consistent on your commits (I see your git name is DaniloBarros, so no problem). But in your 1st commit (8107c9c09360), you are missing the < and > signs around the first email, as shown above.

That is ok, no need to fell sorry, I also believe this will improve future contributions.

I think @gabrielsclimaco uses his nickname in all his commits, so I left that unchanged. But I fixed the <> signs as requested.

Merged. Thanks for the PR.

There is one detail about the PR: when I asked not to include the commented line, you should have not introduced it in the commits at all: you actually introduced it and then removed it later. I wasn't picky about it though.