Issue #3185: buildtag policy test fails for some CGs - koji

koji

#3185 buildtag policy test fails for some CGs

Closed: Fixed Dec 21, 2021 by tkopecek. Opened Dec 16, 2021 by tkopecek.

As CGs don't need to have buildtag attached to buildroots test can fail now (regression #2989)

tkopecek commented Dec 16, 2021

Question is if it is safe to ignore such builds in the policies.

Metadata Update from @tkopecek:
- Custom field Size adjusted to None

Dec 16, 2021

mikem commented Dec 16, 2021

Question is if it is safe to ignore such builds in the policies.

The problem is we have a fairly heterogeneous data set. For most CG builds, the very notion of a build tag test doesn't make sense because there simply isn't a build tag. In such a case, the right thing to do is essentially ignore, as you have in the PR. Policy tests aren't meant to raise routine exceptions.

That said, it's possible that a CG build could actually have a build tag. It's worth thinking about how that would be indicated by the CG and detected in this test. That's future work though.

Metadata Update from @tkopecek:
- Issue tagged with: testing-ready

Dec 16, 2021

jcupova commented Dec 17, 2021

PR 3186

Metadata Update from @mfilip:
- Issue tagged with: testing-done

Dec 20, 2021

tkopecek commented Dec 21, 2021

Commit b69f4b36 fixes this issue

tkopecek commented Dec 21, 2021

Commit dd184320 fixes this issue

mikem commented Apr 22, 2026

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/3185