koji

#4306 failures in tests/test_lib/test_plugin.py
Closed: Fixed by tkopecek. Opened by mikem.

Closed: Fixed
Reopen Issue 
FAILED tests/test_lib/test_plugin.py::TestPluginTracker::test_bad_plugin - AttributeError: 'NoneType' object has no attribute 'origin'
FAILED tests/test_lib/test_plugin.py::TestPluginTracker::test_plugin_path_list - AttributeError: 'NoneType' object has no attribute 'origin'
FAILED tests/test_lib/test_plugin.py::TestPluginTracker::test_plugin_reload - AttributeError: 'NoneType' object has no attribute 'origin'
FAILED tests/test_lib/test_plugin.py::TestPluginTracker::test_tracked_plugin - AttributeError: 'NoneType' object has no attribute 'origin'

This happens because the test code chooses different import machinery than the plugin lib.
Did PR #4249 pass unit tests?

yes, it pass for me (I've "make test" in prepush git hook). Tested now again and can't reproduce this.

Metadata Update from @tkopecek:
- Custom field Size adjusted to None

Hmm, perhaps something strange on my system? But looking at the code, it looks like there is a real mismatch

 
cat .git/hooks/pre-push
#!/bin/sh
make flake8 test3 bandit

Perhaps you are running on a newer python that has already dropped the imp module?
This would force the unit test to use importlib, which was made the secondary choice by #4249

yes py3.13 / F41

Ah, that makes sense then. At any rate, I think the code in #4307 is more correct. The test should match the choice the lib makes
Edited by mikem

Metadata Update from @tkopecek:
- Issue set to the milestone: 1.35.2
- Issue tagged with: easyfix, no_qe

Commit fb2bbaf2 fixes this issue

Commit c3288baa fixes this issue

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/koji/issues/4306

Please continue any further discussion there.
Metadata
None

easyfix no_qe

None
None
Low
None
Related Pull Requests
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.