PR#1005: Add unit tests for check volume id substitution list - - Pagure.io

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.

koji

#1005 Add unit tests for check volume id substitution list

Merged Aug 8, 2018 by mikem. Opened Jul 24, 2018 by jcupova.

jcupova/koji unit-test-volume-id-substitution-list into master

Download 1005.patch

jcupova commented Jul 24, 2018

Added unit tests for this PR https://pagure.io/koji/pull-request/817#request_diff

tkopecek commented Jul 24, 2018

Relict from template, please rename it.

tkopecek commented Jul 24, 2018

Maybe it would be easier to have just one test with list of input/output values. I haven't seen any differences in test functions except this data?

1 new commit added

Change to one test with variants

Jul 25, 2018

2 new commits added

Change to one test with variants
Add unit tests for check volume id substitution list

Jul 25, 2018

tkopecek commented Aug 1, 2018

typo s/substiotutions/substitutions/

tkopecek commented Aug 1, 2018

s/shorten/shortened/

1 new commit added

Fix code review

Aug 1, 2018

mikem commented Aug 8, 2018

Commit a9d23403 fixes this pull-request

Pull-Request has been merged by mikem

Aug 8, 2018

Metadata

Assignee

None

Tags

No Tags

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.