#120 Enable to remove signed rpm
Closed by mikem. Opened by araszka.
araszka/koji master  into  master

Download 120.patch
no initial comment

What is the use case to remove a signed rpm?

rebased

As a part of automated rpm signing process, there is also need to remove signed rpms which will not be shipped.

This change needs access checks. Also naming/signature seems inconsistent with our other signing related calls. I'm not necessarily opposed to adding a feature like this, but I can't take this patch as-is.

Also, do you really want to remove the signature itself. Not a lot of space required for just the signatures. It's the signed copies that consume space.

We have prune_signed_copies in the cli, but that command assumes write access to the volume. If we add hub functionality for this, we should make this usable by prune-signed-copies as well

The only reasons I can think of to remove the actual signature entry (not just signed copy) are:
1. to resign with same key (hopefully a rare occurence)
2. to allow the build to be deleted when the gc policy protects that signature

Which access group do you mean? Admin or sign or any else?
Deleting sign from database and deleting sign header is probably not necessary. I will edit a code to only remove signed rpm.

Still planning on updating this PR?
If you add a call to removed the signed copy, please see writeSignedRPM/write_signed_rpm for reference. The new call should also require the 'sign' permission.

Closing due to lack of activity

Pull-Request has been closed by mikem

Metadata