Rebased to master

the cli options patch needs rebased

Rebased to master.

If the --can-fail option is not used, this line will crash with AttributeError: 'NoneType' object has no attribute 'split'.

I have tested this in staging koji a little.

The code path that does not use this feature is working fine (example task).

When running a spin-livemedia task that should fail on i386 and succeed on x86_64, it all looked fine until the very end, when the toplevel task was marked as failed with result <type 'exceptions.KeyError'>: 'task_id'.

http://koji.stg.fedoraproject.org/koji/taskinfo?taskID=90084435

For the record the full command I used to start that is:

koji spin-livemedia Fedora-Scientific_KDE-Live Rawhide f25 i386,x86_64 fedora-live-scientific_kde.ks '--install-tree=http://kojipkgs.fedoraproject.org/compose/rawhide/Fedora-Rawhide-20161110.n.0/compose/Everything/$basearch/os' '--ksurl=git+https://pagure.io/fedora-kickstarts.git?#881933b138c981abe5a1145412e9c9ecc94e930f' --release=20161110.n.2 '--repo=http://kojipkgs.fedoraproject.org/compose/rawhide/Fedora-Rawhide-20161110.n.0/compose/Everything/$basearch/os' --can-fail=i386

Fixed first one, now looking to second problem.

I'll add special check that if all subtasks fails (and they are listed as can-fail) the parent task will fail. It makes not much sense to successfully close it.

Rebased to current master and added commit for failing parent tasks if all subtasks failed.

This exact line seems to be here twice.

can we please have this rebased

It rebases fine. I have done so here, and added a needed fix:

https://github.com/mikem23/koji-playground/commits/task-fail

If the above looks fine to everyone, I can just merge it

+1

Commit 12c7f891 fixes this pull-request