From 62bbec042f8cd53eedece74aafc89d6e331721f7 Mon Sep 17 00:00:00 2001
From: Tomas Kopecek <tkopecek@redhat.com>
Date: Jan 16 2020 13:38:44 +0000
Subject: don't allow setTaskPriority on closed task


Fixes: https://pagure.io/koji/issue/1153

---

diff --git a/cli/koji_cli/commands.py b/cli/koji_cli/commands.py
index 3b398b5..950fe48 100644
--- a/cli/koji_cli/commands.py
+++ b/cli/koji_cli/commands.py
@@ -6102,7 +6102,10 @@ def handle_set_task_priority(goptions, session, args):
     activate_session(session, goptions)
 
     for task_id in tasks:
-        session.setTaskPriority(task_id, options.priority, options.recurse)
+        try:
+            session.setTaskPriority(task_id, options.priority, options.recurse)
+        except koji.GenericError:
+            warn("Can't update task priority on closed task: %s" % task_id)
 
 
 def handle_list_tasks(goptions, session, args):
diff --git a/hub/kojihub.py b/hub/kojihub.py
index 6f205b8..e44d024 100644
--- a/hub/kojihub.py
+++ b/hub/kojihub.py
@@ -10625,6 +10625,8 @@ class RootExports(object):
         """Set task priority"""
         context.session.assertPerm('admin')
         task = Task(task_id)
+        if task.isFinished():
+            raise koji.GenericError("Finished task's priority can't be updated")
         task.setPriority(priority, recurse=recurse)
 
     def listTagged(self, tag, event=None, inherit=False, prefix=None, latest=False, package=None, owner=None, type=None):