#200 Saving failed build trees
Merged by mikem. Opened by tkopecek.
tkopecek/koji failed-trees  into  master

Download 200.patch

Code for exporting failed trees to tarball placed on hub. It is implemented as hub/builder plugin. When https://pagure.io/koji/issue/193 gets implemented, CLI part can be moved to CLI plugins instead of main CLI file.

Next step will be configurable upload (so different filer can be used for such big files) which can be done in independent PR.

rebased

rebased

rebased

Added configurable stripping of paths and rebase to actual master.

1 new commit added

  • removing already done TODOs

1 new commit added

  • config file

rebased

rebased

rebased

rebased

rebased

Is disable_interspersed_args() needed? Or just carried over from the runroot code

This last if block seems redundant. If we re-raise main do essentially the same thing, right?

should we split on whitespace instead? Easier to read multiple patterns, and more consistent with other pattern options in koji

We should probably assert that this buildroot is ours. A foolish admin could reassign the task, for example.

A bit long for a simple docstring, can we break into summary + details as pep8 suggests?

Also, no need to specify "xmlrpc" here

Might want to fail if original host is disabled

rebased

Comments incorporated + added some basic testing which I've missed to commit (no functional changes).

After digging into this deeper, I realized we needed to focus on buildroot ids instead of task ids, at least under the hood. The reason is that it's possible for a task to restart, and it may have multiple buildroots on multiple hosts.

I've refactored it that way here:
https://github.com/mikem23/koji-playground/commits/failed-trees

It seems to be working for me, but I haven't had time to fix the unit tests yet.

2 new commits added

  • updated tests
  • refactor

I've done some manual testing and updated unit tests also. Only minor check for getBuildroot returning None was added to your patch.

Commit f13d7321 fixes this pull-request

Pull-Request has been merged by mikem@redhat.com

Metadata