koji

#2827 web: don't use count(*) on first tasks page
Merged by tkopecek. Opened by tkopecek.
tkopecek/koji issue2482  into  master

Download 2827.patch

Fixes: https://pagure.io/koji/issue/2482

Overall the code seems to work fine, but I'm a little concerned about the appearance.

With this change, the first page changes from the original heading of

Tasks 1 through 50 of 130 >>>

To simply

>>>

Without the additional text, the ">>>" looks a little strange and might not be as well understand by users. Perhaps we could just change it to something like "Tasks 1 through 50 of 130"?
Edited by mikem

As a result of change we don't know "130", So, something like "Tasks 1 through 50 next page"?

rebased onto f31b7381aaa3d89172a30597a4f9455b802a400d

Sorry, I meant to edit that to remove the 130.

Perhaps just:
"Tasks 1 through 50"
or
""Tasks 1 through 50 of ???"

I guess I'd prefer the first since ??? is distracting.

Ah, that's what you have. Looks fine :thumbsup:

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

Metadata Update from @jobrauer:
- Pull-request tagged with: testing-done

Commit d6694d05 fixes this pull-request

Pull-Request has been merged by tkopecek
Metadata
None

testing-done testing-ready

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.