From 2aa570c85ed9b4bf158e5d48eb682fb55741d320 Mon Sep 17 00:00:00 2001 From: Tomas Kopecek Date: Mar 01 2017 09:39:18 +0000 Subject: Set compatrequests defaults same as requests Python-requests iter_content has chunk_size set to 1. Let's do it same in compatrequests, so we don't confuse users. http://docs.python-requests.org/en/master/_modules/requests/models/#Response.iter_content --- diff --git a/koji/compatrequests.py b/koji/compatrequests.py index 7f6a14d..512ef8c 100644 --- a/koji/compatrequests.py +++ b/koji/compatrequests.py @@ -126,7 +126,8 @@ class Response(object): raise httplib.HTTPException("HTTP %s: %s" % (self.response.status, self.response.reason)) - def iter_content(self, blocksize=8192): + + def iter_content(self, blocksize=1): # should we check this in Session.post()? # should we even check this here? if self.response.status != 200: diff --git a/tests/test_compatrequests.py b/tests/test_compatrequests.py index ba255d4..4056fe7 100644 --- a/tests/test_compatrequests.py +++ b/tests/test_compatrequests.py @@ -47,13 +47,13 @@ class TestResponse(unittest.TestCase): self.response.response.status = 404 self.response.response.getheader.return_value = 0 with self.assertRaises(Exception): - list(self.response.iter_content()) + list(self.response.iter_content(8192)) self.response.response.read.assert_not_called() self.response.response.status = 404 self.response.response.getheader.return_value = 42 with self.assertRaises(Exception): - list(self.response.iter_content()) + list(self.response.iter_content(8192)) self.response.response.read.assert_called_once() self.response.response.status = 404