koji

#2978 Don't take new tasks if we've 0.0 capacity available
Merged by tkopecek. Opened by tkopecek.
tkopecek/koji capacity_race  into  master

Download 2978.patch

If I've just started buildArch task with weight 1.5 on builder with 1.5
capacity, it can pick another one, as it is not over the builder's
capacity. This is wrong as there is no real capacity behind.

@mikem @julian8628

:thumbsup:

With float values like this, the difference between > and >= is not that reliable, but to the extend that this seems to work better in practice, sure. Looks fine.

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-ready

Metadata Update from @tkopecek:
- Pull-request untagged with: testing-ready
- Pull-request tagged with: no_qe

Commit 5e9ca936 fixes this pull-request

Pull-Request has been merged by tkopecek

As a side-effect it delays taking first task in some cases. Reverted for now.
Metadata
None

no_qe

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.