koji

#374 Python 2.4/3.x compatible CLI
Closed by tkopecek. Opened by tkopecek.
tkopecek/koji python3-cli  into  master

Download 374.patch

I've gone once more through and have some 2.4 compatible solution. It has quite a few ugly parts, but it seems to work. If there is anybody willing to test the functionality I would be glad. (CLI tests are already broken for a while for 2.4).

  • krbV support is not there - anyway gssapi should solve all the problems - works for me with Fedora
  • urlgrabber not avaiable in python3 variant - substituted with pycurl and uglier progress bar
  • try/except Exception, e vs Exception as e - I had to remove all of these and reacquire exception via sys.exc_info - ugly
  • Not sure if unicode works correctly everywhere

This should be removed if we're not using it anymore.

1 new commit added

  • remove urlgrabber completely

@ngompa It was used in one more place (kojivmd), but it is oneliner, so it doesn't hurt to remove dependency completely.

1 new commit added

  • group python3 imports

Glad to see things are moving. I hoped that 2.4 would be dropped and wasn't ready to do this kind of hacks. Let me know if I can still help in any way.

With py24 legacy on a separate branch, we are now free to target 2.6+ here, which should help us avoid some of painful workarounds.

Dropping this one, as we have legacy branch. Discussion continues in #151.

Pull-Request has been closed by tkopecek
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.