:thumbsdown:

Looks fine to me. ➕1

@ngompa care to elaborate? It seems highly unlikely that %{_sysconfdir} will even be anything other than /etc. The latter is shorter and more readable. Fedora guidelines have been relaxed on this for years, as the link shows.

So if there is a reason to keep it, I'd like to know. I certainly don't want to break anything.

@mikem Having it macroized is useful for when I build packages to set up for an alternate root (/usr/local, /opt, etc.). I do work from time to time doing it this way.

Also, I think SCLs rely on the usage of those macros so that they can be redefined when you're building packages around core SCLs (think Python SCL and whatnot). Packages built around SCLs use /etc/opt/<vendor>/<scl> instead of /etc for %_sysconfdir.

Just because Fedora has a problem with making it possible to relocate at source build time, doesn't mean everyone else should suffer.

Given that the main reason for this change is aesthetic and we have a reasonable objection, I'm inclined to close this.

scl requires massive invasive macroisation. I do not think that it is a suitable reason for not taking the change.

@ngompa if you are actually doing these things with Koji (i.e. not just a hypothetical problem), I'd be curious to see how it works. Do you really get a working relocated build just by building stock koji with a few macros set?

I'm going to merge this. If it causes a problem, it can be trivially undone with s#/etc/#%{_sysconfdir}/#g

Commit f1da1849 fixes this pull-request