koji

#4383 handle cross-volume draft symlinks
Merged by tkopecek. Opened by mikem.
mikem/koji volume-toplink  into  master

Download 4383.patch

The convenience symlinks generated when promoting a draft build might not work if the build is not on the default volume.

The solution to this is unfortunately a little complicated.

Fixes https://pagure.io/koji/issue/4386

The added unit test demonstrates the problem. It fails on current master and passes with the current changes.

7 new commits added

  • unrelated docs typo
  • update volume docs
  • update tests for add_volume
  • more unit tests
  • don't require new_binfo
  • require volume toplink to exist
  • check/create volume toplink in add_volume

1 new commit added

  • typo

OK, I think this might be about ready.

I'm a little unsure about whether auto-creating toplink in add_volume is the best idea, but it's going to be easier for admins. The docs recommend creating it manually.

1 new commit added

  • clean up test dir

Longer term, we could also use this function to maintain compat symlinks on the old volume when moving across volumes, but I think it would be best to leave that out for now.

:thumbsup:

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-custom

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

Commit 573bd416 fixes this pull-request

Pull-Request has been merged by tkopecek
Metadata
None

testing-custom testing-done

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.