koji

#475 fix StringType and itervalues in plugin and cli
Merged by mikem. Opened by julian8628.
julian8628/koji py3  into  master

Download 475.patch
no initial comment

:thumbsup:

I need one more change here: koji:55 if isinstance(v, six.class_types) instead of isinstance(v, (types.ClassType, types.TypeType))

1 new commit added

  • use six.class_types instead of ClassType, TypeType in cli

I need one more change here: koji:55 if isinstance(v, six.class_types) instead of isinstance(v, (types.ClassType, types.TypeType))

it's done, @tkopecek

Looks good, but wish that unit tests had caught this.

I've added some unit tests for koji.plugin here:
https://github.com/mikem23/koji-playground/commits/pr475

These succeed with on both p2 and py3, and correctly fail on py3 if I revert this fix

rebased

Looks good, but wish that unit tests had caught this.
I've added some unit tests for koji.plugin here:
https://github.com/mikem23/koji-playground/commits/pr475
These succeed with on both p2 and py3, and correctly fail on py3 if I revert this fix

added your tests in and also do some unit tests for cli/koji.load_plugins()
Edited by julian8628

Commit 733dbc4b fixes this pull-request

Pull-Request has been merged by mikem@redhat.com
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.