#625 watch-logs --mine --follow
Merged by mikem. Opened by tkopecek.
tkopecek/koji issue621  into  master

Download 625.patch

Related: https://pagure.io/koji/issue/621

I wonder about setting these options here. Would it be better for _list_tasks to use getattr?
At least worth an explanatory comment.

Also, this approach will break if we add a new option to the list tasks command without also adding it here. That's not necessarily a problem with this approach, but we should probably have a unit test that will catch this. Right now, if I delete one of these options the command fails, but the unit tests pass.

I've moved _list_tasks to lib (as it is now used by more functions) and changed option retrieval to getattr.

1 new commit added

  • move _list_task to client lib

1 new commit added

  • unit test

rebased onto d7ff474678d960cfbe457c0a466499d89c1f15c3

Commit 299e0cda fixes this pull-request

Pull-Request has been merged by mikem@redhat.com

Metadata