The thing is, runroot is not quite like other build commands.

The command is designed to act more like running a command via ssh. That is, you issue the command and then you (eventually) get the output on stdout. This PR changes that behavior, which I'm fairly sure some tools rely upon.

I'm fine with adding a --nowait option as #564 asks. I'm even fine with adding a --watch option (or whatever name) that would give this new behavior. However the existing behavior needs to be preserved by default.

Updated to be backwards compatible. Added some more tests.

the wait option needs default=True, otherwise we change the default behavior

parser.error should always raise an error. There are a few places in the code that we put assert False # pragma: no cover afterwards out of paranoia, but a return is not right.

I assume this is here because of behavior in a unit test where the parser is mocked. We should fix the unit test instead of adding a return here.

the unit test is doing a number of questionable things actually...

I have some unit test cleanup here
https://github.com/mikem23/koji-playground/commits/pagure/pr/633

Commit dec0c7b7 fixes this pull-request