If we're going to import requests_kerberos it seems a little odd to also import HTTPKerberosAuth from it.

Probably want to unit test this. In particular, one to make sure we don't break fallback to old krb when the lib is present but below 0.9.

Perhaps for the check: [int(n) for n in requests_kerberos.__version__.split('.')[:2]] < [0,9]

I'm slightly concerned about possible variations in the version string. Looking upsteam, so far, they have always used integers for the first two parts, though they have used alphanumerics after. I wonder how tolerant we need to be. I suppose we could trap errors.

Hmm, comparing versions is a pain.

Here's the history of their versions from git

[mike@localhost (2)requests-kerberos]$ git log -p -G __version__|grep '^[+]__version'
+__version__ = '0.12.0.beta1'
+__version__ = '0.12.0dev'
+__version__ = '0.12.0a1'
+__version__ = '0.11.0'
+__version__ = '0.10.0'
+__version__ = '0.9.0'
+__version__ = '0.8.0'
+__version__ = '0.7.0'
+__version__ = '0.6.1'
+__version__ = '0.6'
+__version__ = '0.5'
+__version__ = '0.3'
+__version__ = '0.2'
+__version__ = '0.1'

Maybe a different tactic? re.match(r'0[.][1-8]\b', requests_kerberos.__version__)

Updated

Wouldn't it be logged twice here?

Wouldn't it be logged twice here?

Thanks! removed

FYI: I've altered jenkins to install requests-kerberos via pip now, so we don't have failing tests for other PRs. Please remove that install (or ping me) when this one gets merged.

Slight adjustment to error text: https://github.com/mikem23/koji-playground/commits/pagure/pr/753

updated

Commit becc88cb fixes this pull-request

@tkopecek could you help update jenkins config?
I couldn't open https://jenkins.fedorainfracloud.org/ these days...

@julian8628 fixed