Fixes: https://pagure.io/koji/issue/741
I'd rather not default to failure here. The plugin should omit or munge anything it cannot process (and probably log a warning if so). The callback api makes no promises that the data is json encodable.
If we don't have to raise an error, something needs to be returned. I've added there dict with 'error' and 'data' keys, but not sure if it makes sense. Maybe just simple error string?
rebased onto 538cd07d7679b174088ab6661e18b96ce51cbf5f
I'm not sure about the repr here. If we encounter unknown types it might not make sense to dump the repr. Also, users might be tempted to try and scrap that. Maybe just report the type? What do you think? We're still logging the repr on the hub.
2 new commits added
makes sense, I've changed it to str(type(o))
str(type(o))
rebased onto ed8f17923f90f7ac91315feb69506436d26a779a
Looks good. Added a unit test here to get coverage for the plugin back up to 100%
https://github.com/mikem23/koji-playground/commits/pagure/pr/768
:thumbsup:
Commit dad74a3a fixes this pull-request
Pull-Request has been merged by mikem
Fixes: https://pagure.io/koji/issue/741