koji

#77 Allow hiding a user from the frontpage task list.
Merged by mikem. Opened by ralph.
ralph/koji hidden-user  into  master

Download 77.patch

This adds new query arguments to the taskList hub xmlrpc endpoint, and then
makes use of those arguments in koji-web. A new optional configuration value
is added for koji-web: HiddenUser, which can be used to specify which user
account should be hidden. This could be useful for deployments that have a
continuous-integration account, the spam from which makes the frontpage
difficult to read.

Unit test cases are also added for some functions of the hub taskList endpoint.

We want to use this feature in the Fedora deployment to hide the koschei user.

/cc @mizdebsk, @ausil.

rebased

I feel like this should be HiddenUsers, and it should allow multiple userIDs to be specified. We're definitely going to have more than one CI user.

Can do, but that will make the whole change a little more complicated.

If we allow a plural not_owner argument, we should probably also allow a plural owner argument (and so on, and so on...).

I'll do that. The test suite will help to verify that it's not totally bananas. :banana:

2 new commits added

  • Make HiddenUser into HiddenUsers.
  • Remove unused var.

OK, see df13b4d. It's plural now, but it makes the whole change a little more invasive, so, review with caution. :)

1 new commit added

  • Split the HiddenUsers string pulled from our config.

1 new commit added

  • Space-delimited.

+1
Edited by mikeb

I don't see a mechanism for users that do want to see all of the tasks.

Otherwise, the changes look good, and thanks for including tests :clap:

Commit 37ff8d2b fixes this pull-request

Pull-Request has been merged by mikem@redhat.com

Yay! Thanks guys :)
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.