From faf1672199259d27591ee1bbe42fdb25e7a84975 Mon Sep 17 00:00:00 2001 From: Tomas Kopecek Date: Jan 11 2018 11:08:46 +0000 Subject: don't join users table if countOnly Improves performance Fixes: https://pagure.io/koji/issue/782 --- diff --git a/hub/kojihub.py b/hub/kojihub.py index 7e664af..4399cf2 100644 --- a/hub/kojihub.py +++ b/hub/kojihub.py @@ -10305,12 +10305,19 @@ class RootExports(object): opts = {} if not queryOpts: queryOpts = {} + countOnly = queryOpts.get('countOnly', False) tables = ['task'] - joins = ['LEFT JOIN users ON task.owner = users.id'] + if countOnly: + joins = [] + else: + joins = ['LEFT JOIN users ON task.owner = users.id'] flist = Task.fields + ( ('task.request', 'request'), ('task.result', 'result'), + ) + if not countOnly: + flist += ( ('users.name', 'owner_name'), ('users.usertype', 'owner_type'), )