From 974f2d3a6a817526ce23de831788c639c0532600 Mon Sep 17 00:00:00 2001 From: Yuming Zhu Date: Feb 08 2018 05:19:11 +0000 Subject: hub: fix KeyError in `get_notification_recipients` --- diff --git a/hub/kojihub.py b/hub/kojihub.py index 4399cf2..84f5d62 100644 --- a/hub/kojihub.py +++ b/hub/kojihub.py @@ -7143,7 +7143,7 @@ def get_notification_recipients(build, tag_id, state): users_usertypes = [koji.USERTYPES['NORMAL'], koji.USERTYPES['GROUP']] clauses = [ 'status = %(users_status)i', - 'usertype IN %(users_usertype)s', + 'usertype IN %(users_usertypes)s', ] if not build and tag_id: diff --git a/tests/test_hub/test_notifications.py b/tests/test_hub/test_notifications.py index 74573c4..00f79bd 100644 --- a/tests/test_hub/test_notifications.py +++ b/tests/test_hub/test_notifications.py @@ -45,7 +45,7 @@ class TestGetNotificationRecipients(unittest.TestCase): self.assertEqual(q.columns, ('email',)) self.assertEqual(q.tables, ['build_notifications']) self.assertEqual(q.clauses, [ 'status = %(users_status)i', - 'usertype IN %(users_usertype)s', + 'usertype IN %(users_usertypes)s', 'package_id IS NULL', 'tag_id IS NULL', 'success_only = FALSE']) @@ -69,7 +69,7 @@ class TestGetNotificationRecipients(unittest.TestCase): self.assertEqual(q.columns, ('email',)) self.assertEqual(q.tables, ['build_notifications']) self.assertEqual(q.clauses, ['status = %(users_status)i', - 'usertype IN %(users_usertype)s', + 'usertype IN %(users_usertypes)s', 'package_id = %(package_id)i OR package_id IS NULL', 'tag_id IS NULL', 'success_only = FALSE']) @@ -113,7 +113,7 @@ class TestGetNotificationRecipients(unittest.TestCase): self.assertEqual(q.columns, ('email',)) self.assertEqual(q.tables, ['build_notifications']) self.assertEqual(q.clauses, ['status = %(users_status)i', - 'usertype IN %(users_usertype)s', + 'usertype IN %(users_usertypes)s', 'package_id = %(package_id)i OR package_id IS NULL', 'tag_id = %(tag_id)i OR tag_id IS NULL', 'success_only = FALSE'])