What's the use-case?

we want the login button removed in fedora because it is a big support burden. The number of people who screw up the setup and it doesn't work is very high, A large number of new users think they need to login in kojiweb to do things, There is nothing at all that can be done in kojiweb that can not be done on the CLI, we are using external notifications and have disabled koji's notification system.

@ausil: Why not fix it so that the web frontend is easier to work with and can do more things? It seems like a weird regression to just straight-up disable it instead of improving it.

@ngompa the issue is with getting browser certificates working, people screw it up and it can not be made simpler, and there is no use in logging in. All you can do is cancel a task or resubmit a failed one. both things that are really simple to do on the cli.

@ausil: So, essentially, making it so that it doesn't require browser certs (maybe use ipsilion like the rest of infra) is more work for nothing, since the web frontend has no useful functionality at this time?

@ngompa correct.

Being logged in does allow the Summary page to show user-specific data, which some users may find useful.

I very much would appreciate this landing.

Infrastructure folks have spent countless hours with new users on logging in. They don't import the certs right or don't understand how to setup their browser or whatever. So, it takes 30min per user x hundreds of users to get them all logged in, and at the end... there's no advantage. We have taken to telling people to please not bother logging in, we have removed the docs that say you can and should do it, we have made fedora-pacakger only optionally tell you about it and do the certs, but people still the shiny "Login" button and must have it. ;)

So, this would be very helpful for us.

Longer term Patrick has some OAUTH2 patches that should allow koji to use OAUTH2 tokens generated by ipsilon to login (and also hopefully we can drop our cert setup entirely then). But thats down the road...

Longer term Patrick has some OAUTH2 patches that should allow koji to use OAUTH2 tokens generated by ipsilon to login (and also hopefully we can drop our cert setup entirely then). But thats down the road...

Why is this down the road? It seems like something that would be worth putting up as a PR or a branch somewhere now, rather than waiting... @mikem had mentioned in issue #4 that someone had indicated they would do it, but no one had sent any patches.

Because he has not yet had time to finish the patches and test them. He's got a number of other things he is working on and this is not at the top of the list. That said, he's going to try and work on it in the next few weeks....

I have no idea what the intended situation is supposed to look like right now but I do not see the login link: https://fedorahosted.org/fedora-infrastructure/ticket/5321

I'd very much appreciate being able to log in to koji, to have the summary page limited to my stuff.

I'm fine with the feature.

I still need to run some tests, but the change looks fine.

Minor nit: for consistency with other web options, it should be capitalized. E.g. LoginDisabled

I will note that a user with enough knowledge can still login and logout, as the code itself is not disabled, just the login button is removed.

rebased on master and changed loginDisabled to LoginDisabled