librejs

#19 Update for compatibility with Acorn 6.
Merged by quidam. Opened by gioma1.
gioma1/librejs update/acorn6  into  master

Download 19.patch

I had to migrate to a different development environment over the weekend, and while setting up again my local librejs repo, reinstalling all the npm dependencies, I noticed the bundle didn't compile anymore. After a bit of hair pulling, I realized Acorn had a major update and our dependency has been split in 3 separate modules ("acorn", "acorn-loose" and "walk"). Also, the parse_dammit() method we relied upon has been replaced by require("acorn-loose").parse().
So, before going on with the contact finder / complain to owner overhaul, I had to fix quite a few places to let LibreJS keep compiling against up-to-date dependencies.

Since I'm still frantically working on the feature branch, could someone (quidam?) play with this patch to be sure it doesn't cause any major regression?
Thanks!

I see some unrelated changes: cleanup of test_bundle and cleanup of extra tabulation. Could you put those in its own commit? (also, if you are cleaning up the tabulation, I suggest checking if any other files need that)

Unfortunately the cleanup has been done behind my back by Atom (I forgot to configure it not touch spaces on my new development environment).
I removed test_bundle.js from the index because I was touching test.js, and since teest_bundle.js is a build product from the latter, it doesn't make much sense tracking their changes in parallel.
So, do you want me to add a here a new commit including the test_bundle.js duplicate changes and rolling back the whitespace changes, and then move the test_bundle.js untracking (and optionally the accidental tabulation cleanup) to a separate PR?
And what about PR #20? It currently has this one merged (otherwise it couldn't compile): should I try to add a revert commit for the merge? And possibly re-merge this one without the test_bundle.js/whitespace commits?
Edited by gioma1

I guess that is too much work for a technicality, merging as-is.

Pull-Request has been merged by quidam
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.