librejs

#8 Whitelisting bug fixes and blacklisting implementation
Merged by quidam. Opened by gioma1.
gioma1/librejs refactoring/lists  into  master

Download 8.patch

I'm pushing the back-end changes here now to allow quidam to start looking at the code.
I'm still working on the UI side: will add the commits to this PR later, ideally before our afternoon meeting.
Have a nice day!

Forgot to mention: the back-end changes are backwards-compatible both with the "pref_whitelisted" storage entry (so existing users preferences are preserved without special migrations) and with the current UI, even though I'm quite radically changing it to provide better feedback and reflect the mutual exclusivity of the 3 possible policies for each script, i.e. "whitelisted", "blacklisted", "check license every time".

Therefore applying the commits doesn't break the current functionality (beside undetected yet regressions).

4 new commits added

  • Temporarily display back hidden old UI elements to demonstrate whitelisting/backlisting bug fixes.
  • Refactoring out list management in its own class / bug fixing and simplifying UI synchronization.
  • Whitelisted/blackilisted statuses reporting and modification support.
  • Stateful response processing support.

3 new commits added

  • Fixed badge shouldn't be shown on privileged pages.
  • Fixed sub-frames resetting badge to green.
  • Uniform conventions for module importing paths.

2 new commits added

  • UI rewrite for better responsiveness, simplicity and ease of CSS styling.
  • Broader detection of UTF-8 encoding in responses.

1 new commit added

  • Fixed regression, commit #13ea9430ff74174b0e1043119e4d855259b62a30 breaking reporting when intrinsic scripts are detected.

3 new commits added

  • Removed some debugging noise.
  • Fixed scripts whose URLs had a query string could not be whitelisted.
  • Fixed report attempts when no tabId is available.

I've tested the functionality provided by these commits and it aligns with our design and intentions. Excellent work!

Pull-Request has been merged by quidam
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.