mod_nss

#51 Move the SNI hash variables from mod_nss.h to mod_nss.c
Merged by rcritten. Opened by rcritten.
rcritten/mod_nss snivars  into  master

Download 51.patch

gcc in rawhide detects that these variables were declared in any file that imported mod_nss.h. Move them to mod_nss.c instead and declare them as extern in the places they are used.

Also fix the test framework to use python 3 (dropping python 2 support) and do some flake8 cleanup of the python code (mostly dropping unused imports, indentions and unused variables).

I've applied Python2->Python3 part of this PR for ALTLinux. Works good!

I like the shorter version of GCC 10 fixes:
https://pagure.io/fork/slev/mod_nss/c/00f9f6984cde8dac5ba232ec435c4b96c6e3b5b8
but this PR's one is OK for me.

Magic numbers for me. Could you please clarify this?

These are used to categorize ciphers when translating between OpenSSL cipher strings and NSS. I suppose I could have used the NSS versions (e.g. SSL_LIBRARY_VERSION_TLS_1_1) but this isn't doing crypto, just putting the ciphers into buckets.

These are used to categorize ciphers when translating between OpenSSL cipher strings and NSS. I suppose I could have used the NSS versions (e.g. SSL_LIBRARY_VERSION_TLS_1_1) but this isn't doing crypto, just putting the ciphers into buckets.

I see. Thank you!

So is this an ack?

Sorry for delay. Yes, sure.

Pull-Request has been merged by rcritten
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.