PR#16: Improve ./brt_dep_solver.sh to diff_module_deps.py -

modularity / modularity-tools

#16 Improve ./brt_dep_solver.sh to diff_module_deps.py

Merged Apr 27, 2017 by ttomecek. Opened Apr 25, 2017 by dhodovsk.

modularity/ dhodovsk/modularity-tools mod-dep-diff into master

dhodovsk commented Apr 25, 2017

In this PR is our first level dependency resolver rewritten to python and expanded to work with other known modules.

Try this out e.g. by running in modularity-tools repo:
./diff_module_deps.py mariadb --resolve

mkocka commented Apr 26, 2017

What happens with rpm2module.py we dont need it anymore?
Anyway, I tested brt_dep_solver.sh and it is giving reasonable outputs,
but there is an issue when *-caps.txt is not created

e.g.

./brt_dep_solver.sh: line 27: mogodb-filtered-caps.txt: No such file or directory

1 new commit added

Use ModuleDepsDiffer when creating modulemd

Apr 26, 2017

dhodovsk commented Apr 26, 2017

rpm2module is still needed for creating modulemd file, but the issue was, it had used removed ./brt_dep_solver. Issue should now be fixed.

Thank you for pointing this out.

1 new commit added

Fill required dependency modules in modulemd

Apr 27, 2017

ttomecek commented Apr 27, 2017

$ ./diff_module_deps.py gcc
Traceback (most recent call last):
  File "./diff_module_deps.py", line 7, in <module>
    sys.exit(CliModuleDepsDifferHelper.run())
  File "/home/tt/g/modularity-tools/modularity/cli.py", line 112, in run
    mdd.run()
  File "/home/tt/g/modularity-tools/modularity/module_deps_differ.py", line 178, in run
    self.get_package_requires()
  File "/home/tt/g/modularity-tools/modularity/module_deps_differ.py", line 77, in get_package_requires
    ModuleDepsDiffer.package_unique(pkgs)
  File "/home/tt/g/modularity-tools/modularity/module_deps_differ.py", line 110, in package_unique
    raise ValueError('Name of package is not unique')
ValueError: Name of package is not unique