#57 document building container images composed of modules
Closed by nphilipp. Opened by ttomecek.
ttomecek/modularity build-images-from-modules  into  master

Download 57.patch

I would prefer to mention module dist-git and not only dist-git which is used for RPMs.

This I don't understand. The file contains arches and something like platform-master, host-master and shim-master. Nothing like memcached etc.

...and containers and other things. dist-git is by no means limited to RPMs.

I think it's kinda obvious this is about the modules/ namespace.

You need kerberos. Without it you are not able to build container and even not push changes into dist-git.

This is a good comment! The thing is that I haven't found any docs related to building container images in Fedora. Google, here we go.

seems like memcached is not part of the modular rawhide compose; I hope that @jkaluza will be able to give more hints so it's documented better

2 new commits added

  • simplify container img build section
  • s/dist-git/module dist-git/

rebased

@jkaluza @contyk is this true?

@psabata actually

"…reviewer on the Freenode IRC channel…"

"…, the mbs-build command needs to be available on your system."

The article needs to be there, rewording it is optional ;).

"…installing the module-build-service package."

"Building a module"?

How about: "After you have pushed your changes to the dist-git repository, use this command to build your module:"

"…needs to be formally reviewed before becoming part of Fedora . The review process is described in the `Fedora wiki" ←note the moved quote, too

Maybe "have their `own section https://...`__ in the review process document mentioned above."

Do you mean normal, non-modular RPMs here which would end up in updates-testing first, then updates? I'm probably missing background info here :wink:…

"At the time of writing (August 2017), the Fedora…"

"At the time of writing" (without "this") is a set phrase.

@ttomecek I'm done for now :)

Yes, exactly, that process.

@nphilipp updated, is there anything I didn't address?

1 new commit added

  • employ suggestions from Nils

@nphilipp updated, is there anything I didn't address?

There's one missing article ("…the Fedora docker image registry…"), but I can fix that and squash the commits into one if that's okay with you.

I'll just do it :smile:

I've added the missing articles and squashed things in commit 3090525d42450989365a4856557fed146629b55d.

Pull-Request has been closed by nphilipp

Metadata