#84 update defining modules
Closed by nphilipp. Opened by asamalik.
adams-pr1  into  master

Download 84.patch
no initial comment

How about: module-name: stream-name

"…to create an `nginx` module for the NGINX web server, the `nginx` package will be the core."

This is a real-world example so let's provide some context and be a bit more concrete.

Remove most of the commas:

Based on this fill in the `summary`, `description` and `references` fields.
Also add the main package(s) to `components`. ...

"filed"?

Also: we need to agree on a scheme for YAML key paths. We have both notation with dots and slashes ATM.

I think "handy" rather than "useful" expresses better that it's about the specific situation.

"We just need to add the mailcap and gperftools packages in the components.rpm field and the platform module as a runtime dependency."

Let's be explicit about when we mean packages/components or modules.

"With this, we have resolved the runtime dependencies. ..."

"... a set of installation profiles can and at least one should be defined for the module."

"... a database module ..."

"... the user ..."

s/when/if -- not temporal but conditional

1 new commit added

  • fix typos and language errors

@nphilipp thanks for the reviews, I basically agree with all of your comments, and I have applied the changes you have proposed.

Removing this first comma was to zealous by me, should be: "Based on this, …"

It's components.rpms

…this too, and it should be surrounded by backticks.

I've made the changes mentioned above, wrapped lines longer than 80 characters (with exceptions: verbatim blocks, long URLs), fixed a too short title underline and squashed all this into one commit: 608f71d370c41766a7c9830666a3f248f1ad2a5d

Pull-Request has been closed by nphilipp

Metadata