module_diff

#9 module_diff without PDC
Merged by mcurlej. Opened by fivaldi.
fivaldi/module_diff master  into  master

Download 9.patch

This PR switches from PDC to MBS API (data from internal database). It required major code re-factoring, thus some minor improvements are included as well.

  py27: commands succeeded
  py36: commands succeeded
  flake8: commands succeeded
  congratulations :)

rebased onto 0c1b62f879963ef7061b9de5eef0a1c4e3f91f3b

rebased onto d7dc54a1e6987ce85642077a8e83892eb4009ed4

2 new commits added

  • module_diff without PDC (WiP)
  • module_diff without PDC (WiP)

rebased onto a512ac9ac848b2019784f2d73430f1b0baebbeae

@mcurlej Can you take a look, please?
/cc @ralph

@fivaldi LGTM

do we need a try/except blog here? as if the res.json failed then there would more problems like only wrong request. You are checking the request above. Also when you reraise you are losing the original traceback. Removet the excetpiont.

Is there a possibility you could have more than 1 match when searching by all parameters (name, stream, version, context). And if yes shouldnt we return the latest one? Also what will happen if we dont found the NSVC? Shouldnt we say that the module was not found?

I will merge it now and will file an issue for the MBS API error handling, ok? I will submit a PR for it subsequently.

+1

Pull-Request has been merged by mcurlej
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.