#16 Drop detection of only bundled libraries
Opened by sgallagh. Modified
sgallagh/nodejs-packaging bundle_detection  into  master

Download 16.patch

This will ensure that the nodejs(engine) dependency is always added,
along with any Suggests: optionalDependencies.

Signed-off-by: Stephen Gallagher sgallagh@redhat.com

rebased onto c83f06cbf37425e6557b7b4c3f327e79a8e1ebee

Seems reasonable to me.

What about the other things which happen after that, like processing optional dependencies? Do we not need to do that for packages with no dependencies?

@tomh Yeah, that's a good point. I honestly can't think of any reason for this function to even exist.

I'll update the patch.

rebased onto c130ab1221b8e6bf290dd00e09986c87f1cc89cb

Looks like that was indeed suppressing the optionalDependencies. I don't see any reason for this at all, so I just pushed a new version that removes it entirely.

Actually there is a very good reason for it - with that removed we will generate requires for dependencies which have been bundled because the dependencies are generated from package.json without considering if the modules are link or not.

It's not that much better with that though - then it can only handle either "all bundled" or "all unbundled" packages, which would have broken if we had tried to leave clone unbundled from less.

Metadata