Can you actually just add this to the nodejs-packaging package and drop it into /usr/bin instead of making it documentation that we have to copy into every nodejs package we ship? That way we can improve it in one place as well.

Can you actually just add this to the nodejs-packaging package and drop it into /usr/bin instead of making it documentation that we have to copy into every nodejs package we ship? That way we can improve it in one place as well.

I'm concerned about this pulling in lots of dependencies. Maybe as a sub-package. But, let me look and see what happens if I do.

Can you actually just add this to the nodejs-packaging package and drop it into /usr/bin instead of making it documentation that we have to copy into every nodejs package we ship? That way we can improve it in one place as well.

I'm concerned about this pulling in lots of dependencies. Maybe as a sub-package. But, let me look and see what happens if I do.

Looks like the only dependency it adds is bash. I'll do that and update the pull request.

I updated the script so that it checks if npm is installed. By keeping that out of the rpm dependencies we can install this with minimal dependencies. Then only those that need the bundling script will need to install npm.

I've also updated the README.

Could you include this in the sample spec file? I think we probably want to have this file in the %license install-path. Otherwise, I think this looks good. Thanks for the effort you put into this!

Could you include this in the sample spec file? I think we probably want to have this file in the %license install-path.

Very good idea. Updated.

LGTM, thanks!

Oh, sorry. One more request.

Please add nodejs-bundler to nodejs-packaging.spec to install it to /usr/bin.

Once you do that, I'll merge this and build it.

Isn't that backwards. If I update the spec file(downstream), before this merges (upstream), then I have a spec file that cannot build.
I've got a spec file ready, and I've tested it with this. So I certainly can do it. But it seems backwards.

Somehow I had it in my head that #11 was already implemented (largely because I have a commit in my own repo that does so). I need to reconcile that...

Closing this pull request.
This was implemented here
https://src.fedoraproject.org/rpms/nodejs-packaging
with this pull request
https://src.fedoraproject.org/rpms/nodejs-packaging/pull-request/3